issue#130 Update SCORM reset & backup for 4.3 structure.

[joshwillcock]

Hi @danmarsden

Thank you for your work on this fantastic plugin. I have created a fix for #130, hopefully you're happy with with the specific code styling, I have tested this against three datasets and believe the formatting is on point.

I can only PR into an existing branch, but this obviously won't work for 4.1... If you're happy with the changes can you setup a new branch.

Thanks

[danmarsden]

Hey Josh - thanks for working on this! - I see you mention backup in the title but I can't see any changes to the backup code for the new tables - have you got those changes locally? - also I see the privacy:metadata:userid being removed in this patch but I think it's still used in the code (although it shouldn't have the text "H5P" in the string...

thanks!

[joshwillcock]

Hi Dan,

privacy:metadata:userid was in the lang file twice:
111 $string['privacy:metadata:userid'] = 'The user ID linked to this table.';
162 $string['privacy:metadata:userid'] = 'The ID of the user who accessed the H5P activity';

111 Works for any module, line 162 was added in issue21 when adding H5P. Given there is no benefit to having the two different, removing the duplicate alone would allow it to work in SCORM (once again).

With regards to the 'backup' element, I completely missed Moodle's course backup function as in this context I'd associated backup with backing up the SCORM tables into the recompletion_ssv / sa table... I've written the them today but I'm going to change some of the other code so SSV can use courseid as well to make the backups faster... I'll hopefully have this finished by tomorrow.

[joshwillcock]

Hi Dan,

Course backup & restore attached. I've edited the original changes to include the courseid on both sa & ssv to make the process easier.

Thanks

[joshwillcock]

@danmarsden I believe the workflow errors were double spacing on comments related & missing a new line at the end of the file. I've corrected this and gone through all the warnings, I don't believe a single one of the remaining one is related to this patch (but existed before in other sections). If you could approval the workflow run I'll address any failures.

[danmarsden]

Thanks Josh!! - I haven't run this through heaps of testing but didn't see anything I was concerned about in the code - I'll hold off publishing this to the moodle.org plugins db until we get a few people testing it and reporting any issues they find!