Copy default settings to local_recompletion_config on course creation #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmarsden
reviewed
Jul 11, 2024
db/upgrade.php
Outdated
| @@ -987,5 +987,65 @@ function xmldb_local_recompletion_upgrade($oldversion) { | |||
| upgrade_plugin_savepoint(true, 2023112600, 'local', 'recompletion'); | |||
| } | |||
|
|
|||
| if ($oldversion < 2024071100) { | |||
| // We renamed some site admin settings. | |||
There was a problem hiding this comment.
can we create an array with the list of oldname -> newname and then pass it through a foreach loop that calls the work required for this?
Also - we need to use set_config() - not a sql call to update config_plugins entries because config values are cached. (even if we could use sql, you're missing the "where pluginname = 'recompletion" in the sql :-)
eg
$update = ['choice' => 'choiceattempts', 'customcert' => 'customcertificates''];
foreach ($update as $new -> $old {
set_config()
}
aneno-m-e
force-pushed
the
copy-default-on-course-creation
branch
from
25b9c39
to
3602088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.