-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix privacy and add reusable CI #82
Fix privacy and add reusable CI #82
Conversation
Local tests before:
After:
|
Interestingly, phpmd had been enabled previously with no seeming issue:
There are a number of concerns raised which might require some deeper refactoring. Would you prefer the CI for this PR turn it off for now, and separate issues raised for those phpmd violations? |
- Had to enable phpmd check, as it is opt-in by default.
b21ea05
to
d3dc61c
Compare
Turns out I misread the errors and phpcpd is the one returning an error. Similar to how it has been running, I've disabled it so it doesn't make the CI red - with the idea is if it runs, it should be fixed and kept in a good state. There are also some small modifications I made as I worked the file, in particular I moved the handling to a function and aligned the last bit of code for both bulkresetcompletion.php and editcompletion.php, so it's easier to compare and refactor at a later point in time if we want to tackle the phpcpd errors. I can remove all those changes if you think it's easier to maintain in its previous state. |
- phpcpd issues remain, but now are matching 1:1
d3dc61c
to
918bc61
Compare
Resolves #79