Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing privacy string 'local_recompletion_ccert_is' #83

Merged

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Sep 15, 2023

  • Add missing string 'privacy:metadata:local_recompletion_ccert_is'
  • Reorder lang string section

Before:


There was 1 failure:

1) core_privacy\privacy\provider_test::test_metadata_provider with data set "local_recompletion" ('local_recompletion', 'local_recompletion\privacy\provider')
Expectation failed, debugging() was triggered.
Debugging: Invalid get_string() identifier: 'privacy:metadata:local_recompletion_ccert_is' or component 'local_recompletion'. Perhaps you are missing $string['privacy:metadata:local_recompletion_ccert_is'] = ''; in /var/www/site/local/recompletion/lang/en/local_recompletion.php?


After:

❯ ctrl test --filter 'test_metadata_provider'
Moodle 4.1.5+ (Build: 20230908), e87e6c4cff1dfeb0e2a404db88f88ae567703c61
Php: 8.0.29, pgsql: 14.0 (Debian 14.0-1.pgdg110+1), OS: Linux 5.19.0-50-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

...............................................................  63 / 189 ( 33%)
............................................................... 126 / 189 ( 66%)
............................................................... 189 / 189 (100%)


Time: 00:05.900, Memory: 372.00 MB

OK (189 tests, 9515 assertions)

@keevan keevan changed the title 79 missing privacy string Add missing privacy string 'local_recompletion_ccert_is' Sep 15, 2023
@danmarsden danmarsden merged commit 2ed9fc6 into danmarsden:MOODLE_311_STABLE Sep 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants