refactor: Consolidate Message Scrolling & other Logic to Custom Hooks 🔄 #1257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've made significant changes to improve the message scrolling functionality. My main motivation was to eliminate unnecessary prop drilling and the direct invocation of the
ScrollToBottom
method scattered across different components.ScrollToBottom
was being called on each message render; while not a performance blocker, it was unnecessary and added confusing intermingling of logic.To achieve this, I created a custom hook
useMessageScrolling
that centralizes all scrolling logic. Additionally, I introduceduseMessageHelpers
, a new hook dedicated to housing message utilities and abstracting logic away from the main Message component. These changes not only lead to cleaner code and enhanced maintainability, but will pave the way for virtualization in a later update.With the growing number of custom hooks, I am starting to organize these as subfolders in the hooks directory with this update.
Ensured all scrolling behavior works as before.
Change Type
Checklist