Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎚️ fix: Google top_k Slider Step to Integers #4537

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

danny-avila
Copy link
Owner

Summary

I adjusted the step value for the Google topK slider from 0.01 to 1, ensuring integer-only selections for this parameter.

  • Modified the googleSettings object in schemas.ts
  • Changed the step property of the topK setting from 0.01 to 1
  • Maintained the existing min (1), max (40), and default (40) values

Closes #4403

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

To test this change:

  1. Navigate to the Google model settings in the UI
  2. Locate the topK slider
  3. Verify that the slider now moves in whole number increments
  4. Confirm that the minimum (1), maximum (40), and default (40) values remain unchanged

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • I have tested that the topK slider now only allows integer values

@danny-avila danny-avila merged commit e0e393b into main Oct 24, 2024
2 checks passed
@danny-avila danny-avila deleted the fix/google-topk-integer branch October 24, 2024 13:24
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Oct 25, 2024
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Google does not allow TOP_K to be a float, fix the UI slider type
1 participant