Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added ability to send current date and time to v1 and v2 assistants #4833

Closed
wants to merge 2 commits into from

Conversation

maxesse
Copy link
Contributor

@maxesse maxesse commented Dec 2, 2024

Pull Request Template

Summary

Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)
  • Translation update

Testing

Using either OpenAI or Azure assistants (v1 or v2), ask "What is today's date and time without using any tools?". The request will either return that it doesn't know, or a date in 2023.
Open Assistant builder, tick the checkbox "Append current date and time" below the instructions, and ask the same question above. Now the assistant will return your client's date and time.
Should reporting the client time fail for any reason, it will fall back to the server time.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila
Copy link
Owner

thanks opened this in a new PR, removed an unneeded file as well as renaming, typing. #4952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants