🐛 fix: Gemini system instructions not sent with null RAG_API_URL #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-torregrosa
force-pushed
the
gemini-promptprefix
branch
from
bded2c7 to
98c4be9
Compare
alex-torregrosa
changed the title
alex-torregrosa
force-pushed
the
gemini-promptprefix
branch
from
98c4be9 to
4b0195d
Compare
danny-avila
approved these changes
Dec 18, 2024
System instructions were not being sent to gemini models when RAG_API_URL was not set, as the original promptPrefix was not being populated.
alex-torregrosa
force-pushed
the
gemini-promptprefix
branch
from
4b0195d to
5a87d29
Compare
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Dec 20, 2024
…ny-avila#4920) System instructions were not being sent to gemini models when RAG_API_URL was not set, as the original promptPrefix was not being populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
System instructions were not being sent to gemini models when RAG_API_URL was not set, as the original promptPrefix was not being populated.
Change Type
Please delete any irrelevant options.
Testing
Run a gemini model with
RAG_API_URLnot set and ask it "list available artifact types". It will not be able to provide a listChecklist
Please delete any irrelevant options.