Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Correct Model Parameters Merging and Panel UI #5038

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

danny-avila
Copy link
Owner

Summary

I fixed issues with model parameter merging in agent initialization and corrected form field watching in the Model Panel. I also added a reset button for model parameters.

Addresses concern raised by

  • Refactored agent initialization to correctly merge model_parameters with existing endpoint options.
  • Fixed the Model Panel by switching from watch to useWatch in react-hook-form to observe the correct form fields.
  • Added a reset button to the Model Panel to reset model parameters to their default values.
  • Updated localization strings for the reset button label.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested the changes by:

  • Creating new agents and verifying that model parameters are correctly merged during initialization.
  • Checking that the Model Panel now watches and updates the correct form fields.
  • Using the reset button to ensure it resets model parameters to their default values without issues.

Test Configuration:

  • Operating System: [Your OS]
  • Node.js Version: [Your Node.js version]
  • Browser: [Browser used for testing]

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila changed the title 🐛 fix: Correct Model Parameter Merging and Fix Model Panel UI 🐛 fix: Correct Model Parameters Merging and Panel UI Dec 18, 2024
@danny-avila danny-avila merged commit f873587 into main Dec 18, 2024
4 checks passed
@danny-avila danny-avila deleted the fix/agent-model-params branch December 18, 2024 18:54
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Dec 20, 2024
* fix: Model Panel, watching wrong form field

* fix: Refactor agent initialization to merge model parameters correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant