Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Prevent Default Values in OpenAI/Custom Endpoint Agents #5180

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

danny-avila
Copy link
Owner

Summary

I fixed an issue where OpenAI and custom endpoint agents were incorrectly using default values

  • Updated @librechat/agents package to version ^1.9.94 to prevent OpenAI and custom endpoint agents from using default values.
  • Added typing for RunnableConfig in the agents client for improved code quality and readability.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested the application to confirm that the agents now correctly use their specified configuration values and client options are assigned properly. I ensured that there are no new warnings or errors and that all existing tests pass successfully.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 7c61115 into main Jan 4, 2025
2 checks passed
@danny-avila danny-avila deleted the fix/agent-default-options branch January 4, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant