🔖 fix: Remove Local State from Bookmark Menu

[danny-avila]

Summary

I fixed the statefulness issue in the BookmarkMenu component by removing local state and eliminated redundant schema definitions.

• Removed local tags state from BookmarkMenu.tsx, relying on conversation.tags instead.
• Updated code to handle optional tags, adding checks for undefined values to prevent errors.
• Added keyPrefix prop to DropdownPopup component to ensure unique keys in menu items.
• Replaced tPresetUpdateSchema with tConvoUpdateSchema in HeaderOptions.tsx and Panel.tsx to remove redundancy.
• Deleted redundant tPresetUpdateSchema definition from schemas.ts.

Change Type

• Bug fix (non-breaking change which fixes an issue)

Testing

I tested the BookmarkMenu component to ensure that bookmarks are displayed and updated correctly without using local state. I verified that adding, removing, and editing bookmarks work as expected. I also confirmed that removing the redundant schema does not affect application functionality by running existing unit tests and ensuring all tests pass.

Test Configuration

• Operating System: macOS Monterey 12.6
• Node.js Version: 14.17.0
• Browser: Chrome 93.0

Checklist

• My code adheres to this project's style guidelines
• I have performed a self-review of my own code
• I have commented in any complex areas of my code
• I have made pertinent documentation changes
• My changes do not introduce new warnings
• I have written tests demonstrating that my changes are effective or that my feature works
• Local unit tests pass with my changes