-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: Ensure Default ModelSpecs Are Set Correctly #5218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
Followed from the closed #5213 if I set endpoint Ollama instead of the custom, I got error, that Ollama is unknown and that only custom, openai etc can be set as an endpoint. Thanks |
thanks I'm aware and resolving this here |
…rocessing from configuration
…or enhanced endpoint functionality
…in Settings component
…Schema for improved flexibility
1 task
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Jan 21, 2025
* 🐛 fix: default modelSpecs not being set * feat: Add imageDetail parameter for OpenAI endpoints in tQueryParamsSchema * feat: Implement processModelSpecs function to enhance model specs processing from configuration * feat: Refactor configuration schemas and types for improved structure and clarity * feat: Add append_current_datetime parameter to tQueryParamsSchema for enhanced endpoint functionality * fix: Add endpointType to getSaveOptions and enhance endpoint handling in Settings component * fix: Change endpointType to be nullable and optional in tConversationSchema for improved flexibility * fix: allow save & submit for google endpoint
lpirola
pushed a commit
to lpirola/LibreChat
that referenced
this pull request
Jan 22, 2025
* 🐛 fix: default modelSpecs not being set * feat: Add imageDetail parameter for OpenAI endpoints in tQueryParamsSchema * feat: Implement processModelSpecs function to enhance model specs processing from configuration * feat: Refactor configuration schemas and types for improved structure and clarity * feat: Add append_current_datetime parameter to tQueryParamsSchema for enhanced endpoint functionality * fix: Add endpointType to getSaveOptions and enhance endpoint handling in Settings component * fix: Change endpointType to be nullable and optional in tConversationSchema for improved flexibility * fix: allow save & submit for google endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relevant documentation updates: LibreChat-AI/librechat.ai#197
I fixed an issue where default model specifications (modelSpecs) were not being set correctly when there was no default preset, which caused problems during app startup for users without a preset spec. Additionally, I updated type definitions related to user plugins and incremented the data-provider package version.
useAppStartup.ts
to set default modelSpecs whendefaultPreset
is not available.fakeData
fromuseAppStartup.ts
.TUser
type indata-provider
to make theplugins
field optional.librechat-data-provider
package version from0.7.691
to0.7.692
inpackage.json
.EditMessage.tsx
.tConversationSchema
to makeendpointType
nullable and optional for improved flexibility.endpointType
togetSaveOptions
inGoogleClient.js
and enhanced endpoint handling in theSettings
component.append_current_datetime
parameter totQueryParamsSchema
to improve endpoint functionality.processModelSpecs
function to enhance model specs processing from configuration.imageDetail
parameter for OpenAI endpoints intQueryParamsSchema
for better image processing options.modelSpecs
were not being set during application startup.Change Type
Testing
I tested these changes by running the application locally and verifying that default modelSpecs are correctly set for users without a preset spec. I also tested the app startup process to ensure that the app title and available plugins are configured as expected, and that there are no regressions for existing users.
Checklist