🔗 feat: Enhance Share Functionality, Optimize DataTable & Fix Critical Bugs #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berry-13
changed the title
|
Thanks @berry-13 Please un-draft and mention me when ready! Also:
|
berry-13
force-pushed
the
refactor/share-link
branch
from
7e28df2 to
c255687
Compare
|
@danny-avila ready |
…hare link; feat: refresh link
…parameters and response structure
…place pageNumber with cursor for improved data fetching
… shared link model and update related components
…elete mutation and confirmation dialog
…d search functionality; update search handling in API and localization
…ty and loading states, optimize AnimatedSearchInput, and refine DataTable scrolling behavior
danny-avila
force-pushed
the
refactor/share-link
branch
from
3fce5a9 to
1ecfaf3
Compare
… existing shared links, and remove deprecated .exec() method for queries
lpirola
pushed a commit
to lpirola/LibreChat
that referenced
this pull request
Jan 22, 2025
…l Bugs (danny-avila#5220) * 🔄 refactor: frontend and backend share link logic; feat: qrcode for share link; feat: refresh link * 🐛 fix: Conditionally render shared link and refactor share link creation logic * 🐛 fix: Correct conditional check for shareId in ShareButton component * 🔄 refactor: Update shared links API and data handling; improve query parameters and response structure * 🔄 refactor: Update shared links pagination and response structure; replace pageNumber with cursor for improved data fetching * 🔄 refactor: DataTable performance optimization * fix: delete shared link cache update * 🔄 refactor: Enhance shared links functionality; add conversationId to shared link model and update related components * 🔄 refactor: Add delete functionality to SharedLinkButton; integrate delete mutation and confirmation dialog * 🔄 feat: Add AnimatedSearchInput component with gradient animations and search functionality; update search handling in API and localization * 🔄 refactor: Improve SharedLinks component; enhance delete functionality and loading states, optimize AnimatedSearchInput, and refine DataTable scrolling behavior * fix: mutation type issues with deleted shared link mutation * fix: MutationOptions types * fix: Ensure only public shared links are retrieved in getSharedLink function * fix: `qrcode.react` install location * fix: ensure non-public shared links are not fetched when checking for existing shared links, and remove deprecated .exec() method for queries * fix: types and import order * refactor: cleanup share button UI logic, make more intuitive --------- Co-authored-by: Danny Avila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description:
🎯 Objective: Significantly enhance the
Sharefunctionality, optimize data handling, and resolve critical bugs💥 Error Handling Improvements:
ShareServiceErrorclass for detailed error management withinapi/models/Share.js⚡ ID Anonymization Optimization:
api/models/Share.js🚀 API Enhancements:
getSharedLinksto enable cursor-based pagination and search inapi/models/Share.jsapi/models/Share.jsapi/server/routes/share.js[1] [2] [3]🔧 Schema and Client Updates:
isVisibleandisAnonymousfromshareSchemainapi/models/schema/shareSchema.jsShareButtonwithuseGetSharedLinkQueryfor retrieving shared link data and added QR code generation inclient/src/components/Conversations/ConvoOptions/ShareButton.tsx🐛 Bug Fixes & Improvements (Closes [Bug]: Incorrect Title when Sharing the Chat & Managing The Shared Links #5282):
generateLinkis clickedDataTablecomponent for handling infinite items (tested with 100,000 elements with no lag)🔄 Known Issues:
🔍 Ongoing adjustments required for search inDataTableDataTablecache logicChange Type
Testing
Tested main features (Share, Convo, Messages) with:
Test Configuration:
Checklist