Dx improvements

[xendk]

Minor improvements to docker setup.

[kasperg]

👍

I do not agree with removing the default COMPOSE_PROJECT_NAME. I have tried to argue my case. If you still insist then let's merge.

[kasperg]

Personally I do not see this as a DX improvement.

We have a handful of different aspects of the project which require the host name to be dpl-cms.docker including OpenID Clients for Adgangsplatformen set up by DBC.

I know that COMPOSE_PROJECT_NAME will default to the name of the current directory, that Git will use the repository name by default when cloning, that GitHub Actions checkout will not provide a custom directory name by default etc.

If some of these assumptions do not hold then you are going to run into problems with non-obvious solutions.

To me it is preferable to avoid these by ensuring a default host name.

If someone wants to run multiple instances they are free to edit their local .env file. This would be a one-time workflow for them.

[xendk]

We have a handful of different aspects of the project which require the host name to be dpl-cms.docker

I'll argue that the two TS files should be fixed so they can sniff out the proper hostname. This is precisely the kind of hardcoding that can come back to bite you some day.

As for the MD files: One could argue for replacing dpl-cms.docker with <your local environment>, but that kind of placeholdering quickly grows tiresome. I'm sure that anyone that's actually using a different hostname can mentally substitute.

including OpenID Clients for Adgangsplatformen set up by DBC.

That's unfortunate, and I guess they don't support wildcards either? But I'd more consider that a limitation of running more than one instance. In my case, it means I can't use Adgangsplatformen at all, because I don't have any .docker mapping (maybe I can get past that with good old /etc/hosts, but the DX will suck).