Reader / Player #1859
Open
Reader / Player #1859
+106
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/reader` route now passes either the `identifier` or `orderId` parameters to the `Reader` React app. This was implemented to ensure the proper loading of external scripts that require a full page reload.
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
This caused issues when passing the URL parameter from Drupal into the `Reader` app. Additionally, I have set the default value of `orderid` to an empty string, similar to how `identifier` is handled.
The `reader-modal-description-text` is no longer utilized.
- Removed unnecessary comments
- Removed redundant div wrapper.
- Removed the `{{ drupal_block('system_messages_block') }}`. as it not needed here
Remove the unnecessary inclusion of the `Reader` react app within a Block. Instead, render the `Reader` app at the `/reader` route, with the identifier or order ID as optional parameters. The app will be rendered using the `page--reader.html.twig` template, which does not include a header or footer.
Using `BadRequestHttpException` results in an HTTP 400 error response, which correctly signals a client error, making the API behavior more RESTful and easier to debug for clients.
…anonymous-and-logged-in-user-can-try-ebook DDFBRA-183 - Anonymous and logged in user can try ebook + audiobook
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
…logged-in-user-can-go-from-digital-loans-to-material-to-listen-read DDFBRA-236 - Logged in user can go from digital loans to material to listen read
…logged-in-user-can-open-their-loaned-e-material DDFBRA 251 - logged in user can open their loaned e material
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-182
https://reload.atlassian.net/browse/DDFBRA-251
https://reload.atlassian.net/browse/DDFBRA-236
Pull requests
#1779
#1814
#1854
Description
This pull request consolidates all features related to Reader/Player functionality, streamlining the integration and development process.
See video in this PR: danskernesdigitalebibliotek/dpl-react#1596
Test
https://varnish.pr-1859.dpl-cms.dplplat01.dpl.reload.dk/