Event date facet (DDFFORM-67) #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal libraries go at the top alphabetically, internal at the bottom.
Add a date facet and the facet date range module. Render the new date facet on the event list and use the design system to enhance it with a date range element.
For this to work we have to provide our own behavior which in turn can use JavaScript from the design system. Unfortunately this also requires a bunch of patches.
Load the translation and pass the proper configuration to Flatpickr.
kasperg
force-pushed
the
event-date-facet
branch
from
c9d193e to
59cea6e
Compare
LasseStaus
requested changes
Mar 22, 2024
There was a problem hiding this comment.
I think there are some issues with this.
Since most of this logic comes from the design system, i will add most of my thoughts in the design system.
So some things i have tested here in the cms, will be highlighted in the design PR with suggestions.
Two things for the cms tho:
- If i select a date range, and reload the page, the css dosn't gets rendered for me.
- If i select a date range that contains 0 results, the rest of the filters goes away. I guess this is default behaviour with the current setup, but if we could keep them visible instead of them disappearing i think that would be a plus. ➕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-67
Description
This PR adds support for filtering events by date. The PR consists of:
Please go through the individual commits for additional commentary.
Screenshot of the result
Additional comments or questions
This PR depends on the related changes in the design system: danskernesdigitalebibliotek/dpl-design-system#562