Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KBHBIB-24 Added new share buttons #796

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Dec 5, 2024

Link to issue

Please add a link to the issue being addressed by this change.

Description

  • Added share button component with inline and fixed buttons for sharing current page on Facebook or copying the URL to clipboard

Screenshot of the result

Fixed buttons
image

Inline buttons
image

@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons branch 3 times, most recently from 2f2a333 to 8dfc0a8 Compare December 10, 2024 13:34
As icons were not orignally added with the ability to inherit color, a change to facebook icon is necessary for the svg to change color with button hovor.
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons branch from 8dfc0a8 to 944fdea Compare December 10, 2024 14:04
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons branch from 944fdea to 838643b Compare December 10, 2024 14:59
@JacobArrow JacobArrow changed the title KBHBIB-24-share-buttons KBHBIB-24 Added new share buttons Dec 10, 2024
@JacobArrow JacobArrow marked this pull request as ready for review December 10, 2024 15:15
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of comments that I'd like you to look at.
Also, is there a third PR for the dpl-react repo? Or have I already looked at that one and just can't remember?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants