Fix PHPDoc and a dry run parameter for generateLabel

dansmaculotte · Jan 3, 2019 · 9348295 · 9348295 · gaelreyrol · Jan 3, 2019
1 parent 3b71de8
commit 9348295
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/ParcelTracking.php b/src/ParcelTracking.php
@@ -35,7 +35,7 @@ public function __construct(array $credentials, array $options = array())
      * @return ParcelStatus
      * @throws \Exception
      */
-    public function getStatusByID($id, $options = array())
+    public function getStatusByID(string $id, array $options = array())
     {
         $options = array_merge(
             array(

diff --git a/src/Postage.php b/src/Postage.php
@@ -20,20 +20,21 @@ class Postage extends Client
      *
      * @throws \Exception
      */
-    public function __construct($credentials, $options = array())
+    public function __construct(array $credentials, array $options = array())
     {
         parent::__construct($credentials, self::SERVICE_URL, $options);
     }
 
     /**
-     * @param string $outputFormat ToDo
-     * @param string $letter       ToDo
-     * @param array  $options      Additional parameters
-     * 
+     * @param array $outputFormat ToDo
+     * @param array $letter       ToDo
+     * @param bool  $check        Perform dry run instead of real method usage
+     * @param array $options      Additional parameters
+     *
      * @return Object
      * @throws \Exception
      */
-    public function generateLabel($outputFormat, $letter, $options = array())
+    public function generateLabel(array $outputFormat, array $letter, bool $check = false, $options = array())
     {
         $options = array_merge(
             array(
@@ -44,7 +45,7 @@ public function generateLabel($outputFormat, $letter, $options = array())
         );
 
         $result = $this->soapExec(
-            'generateLabel',
+            ($check) ? 'checkGenerateLabel' : 'generateLabel',
             $options
         );