Skip to content

Commit

Permalink
use new kv store
Browse files Browse the repository at this point in the history
  • Loading branch information
pablodanswer committed Oct 6, 2024
1 parent a7b0a0d commit b579648
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
9 changes: 3 additions & 6 deletions backend/danswer/key_value_store/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from sqlalchemy.orm import Session

from danswer.db.engine import get_session_factory
from danswer.db.engine import get_sqlalchemy_engine
from danswer.db.models import KVStore
from danswer.key_value_store.interface import JSON_ro
from danswer.key_value_store.interface import KeyValueStore
Expand All @@ -26,12 +26,9 @@ def __init__(self) -> None:

@contextmanager
def get_session(self) -> Iterator[Session]:
factory = get_session_factory()
session: Session = factory()
try:
engine = get_sqlalchemy_engine()
with Session(engine, expire_on_commit=False) as session:
yield session
finally:
session.close()

def store(self, key: str, val: JSON_ro, encrypt: bool = False) -> None:
# Not encrypted in Redis, but encrypted in Postgres
Expand Down
12 changes: 6 additions & 6 deletions backend/danswer/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
from danswer.db.swap_index import check_index_swap
from danswer.document_index.factory import get_default_document_index
from danswer.document_index.interfaces import DocumentIndex
from danswer.dynamic_configs.factory import get_dynamic_config_store
from danswer.dynamic_configs.interface import ConfigNotFoundError
from danswer.indexing.models import IndexingSetting
from danswer.key_value_store.factory import get_kv_store
from danswer.key_value_store.interface import KvKeyNotFoundError
from danswer.natural_language_processing.search_nlp_models import EmbeddingModel
from danswer.natural_language_processing.search_nlp_models import warm_up_bi_encoder
from danswer.natural_language_processing.search_nlp_models import warm_up_cross_encoder
Expand Down Expand Up @@ -134,7 +134,7 @@ def setup_danswer(db_session: Session) -> None:


def translate_saved_search_settings(db_session: Session) -> None:
kv_store = get_dynamic_config_store()
kv_store = get_kv_store()

try:
search_settings_dict = kv_store.load(KV_SEARCH_SETTINGS)
Expand Down Expand Up @@ -172,17 +172,17 @@ def translate_saved_search_settings(db_session: Session) -> None:
logger.notice("Search settings updated and KV store entry deleted.")
else:
logger.notice("KV store search settings is empty.")
except ConfigNotFoundError:
except KvKeyNotFoundError:
logger.notice("No search config found in KV store.")


def mark_reindex_flag(db_session: Session) -> None:
kv_store = get_dynamic_config_store()
kv_store = get_kv_store()
try:
value = kv_store.load(KV_REINDEX_KEY)
logger.debug(f"Re-indexing flag has value {value}")
return
except ConfigNotFoundError:
except KvKeyNotFoundError:
# Only need to update the flag if it hasn't been set
pass

Expand Down

0 comments on commit b579648

Please sign in to comment.