Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Search #1961

Closed
wants to merge 1 commit into from
Closed

Improve Search #1961

wants to merge 1 commit into from

Conversation

yuhongsun96
Copy link
Contributor

@yuhongsun96 yuhongsun96 commented Jul 28, 2024

Description

  • Remove N-Grams
  • Normalize Titles and Contents before combining
  • Title vector is strictly a boost, title vector score is never lower than the content

How Has This Been Tested?

Upgrade with existing index still works (however ngram quality improvement does not happen)

Accepted Risk

There may be weird interactions of ngram-ed docs and non-gram-ed docs

Related Issue(s)

NA

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 1:35am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant