Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack indexing: add name to each user contributing to a thread #1992

Closed
wants to merge 0 commits into from

Conversation

danielnaber
Copy link
Contributor

Description

danswer misattributed facts from threads in Slack in my tests (i.e. claimed that X said something when it was actually someone else from the thread who said it). Adding the author's name seems to help with that.

I also changed the __main__ part to be more useful for testing -> print all docs, not just the first one.

How Has This Been Tested?

Manually tested results with a few cases. Indexing works with a large Slack instance with >50K docs indexed.

Accepted Risk

I'm not aware of any risks (but I'm not very experienced with writing connectors).

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Jul 31, 2024

@danielnaber is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant