Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate api keys #2511

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Obfuscate api keys #2511

wants to merge 12 commits into from

Conversation

pablodanswer
Copy link
Contributor

@pablodanswer pablodanswer commented Sep 19, 2024

Description

We must stop sending API keys to the client side!

All API keys will now only be stored in Request models and passed around server side.

How will this work?

When updating a model with an API key, we cannot pass the API key to the update request, so we must be able to specify requests without API keys (here, we specifiy api_key_set to ensure that we acutally update the value if necessary.

Separately we can use the term contains_api_key to signify that an api key exists for a given model we're returning

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ❌ Failed (Inspect) Sep 20, 2024 2:20am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant