(minor) search memoization + context #2732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablodanswer
changed the title
pablodanswer
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces minor enhancements to multi-tenancy support and markdown rendering optimization in the DAnswer project.
- Modified
get_sessioninbackend/danswer/db/engine.pyto retrieve tenant ID fromcurrent_tenant_idcontext variable before creating a database session - Implemented memoization in
web/src/components/chat_search/MinimalMarkdown.tsxformarkdownComponentsobject, dependent on thecontentprop - Added
useMemohook in MinimalMarkdown component to potentially improve rendering performance - Ensured correct tenant schema is set for each database session in multi-tenant scenarios
- Updated
markdownComponentsto include memoized versions of Link and Paragraph components
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| () => ({ | ||
| a: MemoizedLink, | ||
| p: MemoizedParagraph, | ||
| code: ({ node, inline, className, children, ...props }: any) => { |
There was a problem hiding this comment.
style: The 'inline' and '...props' parameters are unused. Consider removing them if not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: