backport update indexing and slack bot to use stdout options (#2752) #2755
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the supervisord.conf file to improve log management in a Docker environment, focusing on directing logs to stdout for better containerized application practices.
- Removed LOG_FILE_NAME environment variable from document_indexing program
- Added stdout_logfile and stdout_logfile_maxbytes options for each program (document_indexing, celery_worker, celery_beat, slack_bot)
- Updated log-redirect-handler to tail the new log files, ensuring all logs are properly captured and redirected to stdout
- These changes enhance logging setup for improved performance monitoring and Docker compatibility
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -31,15 +32,17 @@ command=celery -A danswer.background.celery.celery_run:celery_app worker | |||
| --loglevel=INFO | |||
| --logfile=/var/log/celery_worker_supervisor.log | |||
There was a problem hiding this comment.
logic: The --logfile option for celery_worker is still present, which may conflict with the new stdout_logfile configuration.
| @@ -31,15 +32,17 @@ command=celery -A danswer.background.celery.celery_run:celery_app worker | |||
| --loglevel=INFO | |||
| --logfile=/var/log/celery_worker_supervisor.log | |||
| -Q celery,vespa_metadata_sync,connector_deletion | |||
| environment=LOG_FILE_NAME=celery_worker | |||
| stdout_logfile=/var/log/celery_worker.log | |||
| stdout_logfile_maxbytes=16MB | |||
| redirect_stderr=true | |||
| autorestart=true | |||
|
|
|||
| # Job scheduler for periodic tasks | |||
| [program:celery_beat] | |||
| command=celery -A danswer.background.celery.celery_run:celery_app beat | |||
| --logfile=/var/log/celery_beat_supervisor.log | |||
There was a problem hiding this comment.
logic: The --logfile option for celery_beat is still present, which may conflict with the new stdout_logfile configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: