Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candle Chart renderer added, Gallery updated too #141

Closed
wants to merge 3 commits into from

Conversation

jerryzhenleicai
Copy link

Please check out the Candler Chart Demo (under Stock Demo). I added a new option called "renderer" which can be either "line" or "candle".

@danvk
Copy link
Owner

danvk commented Apr 6, 2012

Hi,

Sorry I've been slow to respond to this. Overall I think it looks greats and I really like the functionality. The thing that gives me pause is that we're in the process of moving to a "plugin" architecture for dygraphs, and I'm a bit reluctant to commit to new APIs like this while we're in the process of figuring that out.

I will keep you updated as things settle. This will be a great test case for our new plugin system—if we can't support something like this, then we're probably not designing it well.

  • Dan

@danvk danvk closed this Jul 31, 2012
@MarkusTeufelberger
Copy link

Any news on having a candle chart plugin? I'd love to see this kind of charts, potentially with more data around (for reference, I'd like to recreate the charts on http://bitcoincharts.com/charts/ in Javascript and load them dynamically.

@kberg
Copy link
Collaborator

kberg commented Nov 7, 2013

@MarkusTeufelberger
Copy link

I did see it, this pull request is mentioned in the comments actually... that's why I came here in the first place.

@danielkrizian
Copy link

Just FYI, the rebirth of the candlestick chart development here: #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants