Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do Not Land] #15726

Draft
wants to merge 7 commits into
base: google/2.6
Choose a base branch
from
Draft

[Do Not Land] #15726

wants to merge 7 commits into from

Conversation

mlawsonca
Copy link
Collaborator

@mlawsonca mlawsonca commented Jan 13, 2025 •
edited
Loading

Run-GHA: True
Required-githooks: true
Skip-build: true
Skip-test: true
Skip-unit-tests: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mlawsonca
Test commit
c8e46c7 
Run-GHA: True
Required-githooks: true

Signed-off-by: Margaret Lawson <[email protected]>
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/[Do

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2025
View reviewed changes
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
.github/workflows/md-on-ssd-tests.yml Fixed Show fixed Hide fixed
@mlawsonca
Add GHA workflow to run GCP weekly tests
155432c 
Runs DFUSE and md-on-ssd ftests, md-on-ssd unit tests

Required-githooks: true
Skip-test: true
Skip-unit-test: true

Signed-off-by: Margaret Lawson <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 15, 2025
View reviewed changes
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
.github/workflows/gcp-weekly.yml Fixed Show fixed Hide fixed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Functional on EL 8.8 Test Results (old)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 15f87b2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Functional on EL 9 Test Results (old)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 15f87b2.

♻️ This comment has been updated with latest results.

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15726/2/testReport/

@mlawsonca
Bug fixes for new GCP weekly workflow
99b8ba7 
Adjust provision-cluster to work for scheduled events
Add in missing conditions when invoking provision-cluster
Make Docker unit tests runs privileged (to avoid sudo errors)

Skip-build: true
Skip-test: true
Skip-unit-tests: true
Required-githooks: true

Signed-off-by: Margaret Lawson <[email protected]>
@mlawsonca mlawsonca force-pushed the mlawsonca/google_add_md_on_ssd_workflow branch from 15f87b2 to 99b8ba7 Compare January 15, 2025 21:23
@mlawsonca
Remove unit tests, this is already being done
c218406 
Required-githooks: true

Signed-off-by: Margaret Lawson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15726/5/testReport/

@mlawsonca
Fix bug that causes post-provisioning to fail
a6aaa55 
Required-githooks: true

Signed-off-by: Margaret Lawson <[email protected]>
@mlawsonca
Pin GHA action versions for Scorecard
19ae3c4 
Signed-off-by: Margaret Lawson <[email protected]>
@mlawsonca mlawsonca force-pushed the mlawsonca/google_add_md_on_ssd_workflow branch from 96d6155 to 19ae3c4 Compare January 17, 2025 00:02
@mlawsonca
Add pinning for remaining GHA actions, fix hash bug
00d590a 
Run-GHA: True
Required-githooks: true
Skip-build: true
Skip-test: true
Skip-unit-tests: true

Signed-off-by: Margaret Lawson <[email protected]>
@mlawsonca mlawsonca force-pushed the mlawsonca/google_add_md_on_ssd_workflow branch from 2633f03 to 00d590a Compare January 17, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlawsonca @daosbuild1