Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various enhancements #117

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Various enhancements #117

merged 4 commits into from
Feb 26, 2024

Conversation

robertkiel
Copy link
Contributor

@robertkiel robertkiel commented Feb 22, 2024

Re hoprnet/hoprnet#5951

Invalid links

Setting the mainService property in dappnode_package.json assigns the main DNS entry, in this case hopr.public.dappnode to the defined service, which in our case is node.

This PR changes all URLs directing to node.hopr.public.dappnode to hopr.public.dappnode, including the prometheus target

Yarn removal

The dappnodesdk uses npm and npx (npx @dappnode/dappnodesdk build) and refuses to work with yarn for unknown reasons. This PR removes all yarn-related settings and files.

Enhance development documentation

This PR adds helpful information on how to build and debug DAppnode packages. See DEVELOPMENT.md

Out of scope

  • Automatic import of prebuild Grafana dashboards as it appears to be broken at the moment.
  • Automatic retrieval of IPFS hash when releasing package
  • Automatic patching of Grafana dashboard (take the one used in Kubernetes and adapt it for DAppnode) by replacing incorrect entries with jq

@robertkiel robertkiel changed the title Fix internal URLs Fix internal URLs & remove unnecessary yarn Feb 23, 2024
@robertkiel robertkiel changed the title Fix internal URLs & remove unnecessary yarn Various enhancements Feb 23, 2024
DEVELOPING.md Show resolved Hide resolved
dappnode_package.json Show resolved Hide resolved
@NumberFour8 NumberFour8 merged commit 5e73f32 into dappnode:main Feb 26, 2024
2 checks passed
@tolbrino tolbrino deleted the robertkiel/fix-url branch May 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants