Prepare dappmanager for multi-service nimbus client #2014
Conversation
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 7b9b8cd This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
dappnodedev
force-pushed
the
feature/migrate-nimbus-to-2-services
branch
from
e8f2ed5
to
613f974
Compare
| } else { | ||
| // Lighthouse, Teku and Prysm use 3500 | ||
| // Nimbus uses 4500 because it is a monoservice and the validator API is using that port | ||
| if (dnpName.includes("nimbus")) { |
There was a problem hiding this comment.
All production Nimbus clients have their driver defined like this:
"chain": {
"driver": "ethereum-beacon-chain",
"serviceName": "beacon-validator",
"portNumber": 4500
},
So it is not necessary to consider this condition. Also, once nimbus package is published from https://github.com/dappnode/DAppNodePackage-nimbus-generic , it will have 2 services that will behave the same as the rest of the clients
| }, | ||
| environment: { | ||
| // TODO: Remove once Nimbus is split into 2 services | ||
| [beaconValidatorServiceName]: { |
There was a problem hiding this comment.
It is okay to include it in all cases, because the applyUserSettings function will only take into account the existing services in the compose of the package to install/start:
We are going to migrate from monoservice nimbus client to a new version that includes:
beacon-chainvalidatorbeacon-validator--> This is a proxy that forwards request following this pattern:This PR removes logic related to beacon-validator service
It is important to design a proper migration strategy, as publishing a new Dappmanager version including this changes will cause the previous versions of Nimbus client to fail if selected in the Stakers tab