-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure requirements in packageInstall
and not only on fetchDnpRequest
#2054
Merged
pablomendezroyo
merged 8 commits into
develop
from
pablo/ensure-install-requirements-always
Nov 6, 2024
Merged
Ensure requirements in packageInstall
and not only on fetchDnpRequest
#2054
pablomendezroyo
merged 8 commits into
develop
from
pablo/ensure-install-requirements-always
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1968 |
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 7464b6b This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
Marketen
approved these changes
Nov 5, 2024
pablomendezroyo
changed the title
ensure requirements in
Ensure requirements in Nov 6, 2024
packageInstall
and not only on fetchDnpRequest
packageInstall
and not only on fetchDnpRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure requirements in
packageInstall
and not only onfetchDnpRequest
.This will affect mainly auto updates as long as the install from the dappstore is already tracked with the compatible data