Mateu/add_smooth_to_import_view #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2023 12:31
… Smooth (only in pratter and mainnet)
pablomendezroyo
requested changes
Jan 2, 2024
packages/ui/src/ImportScreen.tsx
Outdated
| } | ||
| onChange={(e) => { | ||
| setUseSameTag(!useSameTag); | ||
| if (!e.target.checked) { |
There was a problem hiding this comment.
You should use instead a useEffect at the top of the component that will be triggered on useSameTag value changes
| @@ -274,22 +291,53 @@ export default function ImportScreen({ | |||
| }} | |||
| > | |||
There was a problem hiding this comment.
Would not be more straight forward to implement here something like
{ tag === "solo" && <MenuItem...| @@ -331,7 +380,14 @@ export default function ImportScreen({ | |||
| useSameFeerecipient, | |||
| getFeeRecipientFieldHelperText, | |||
| isFeeRecipientFieldWrong, | |||
| tagSelectOptions | |||
| tagSelectOptions, | |||
There was a problem hiding this comment.
Are you sure you need all of these new args? could some of them be removed or declare in this component?
added 7 commits
January 2, 2024 13:34
|
reopen if required. Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adding smooth fee recipient when the user checks "Solo" as protocol and "I want to join Smooth"