New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proof of validation #304

Merged

pablomendezroyo merged 28 commits into main from pablo/add-validator-monitoring

May 31, 2024

Contributor

pablomendezroyo commented Mar 13, 2024

Implement proof of validation.

Depends on web3signer implementation

pablomendezroyo requested a review from a team as a code owner

March 13, 2024 11:04

pablomendezroyo marked this pull request as draft

March 13, 2024 11:04

pablomendezroyo marked this pull request as ready for review

March 19, 2024 12:25

pablomendezroyo added 4 commits

March 19, 2024 13:26


          Implement signDappnodeProofOfValidation

58a66b9


          split cron

a907b67


          implement proover

ecdef33


          fix cron test imports

0b0b40b

pablomendezroyo force-pushed the pablo/add-validator-monitoring branch from 18c0ab6 to 0b0b40b Compare

March 19, 2024 12:27

pablomendezroyo added 6 commits

March 19, 2024 13:30


          use of modules exports

d9222f7


          add envs

3f5102b


          fix apis

46d2fe3


          add typ cast

e298062


          fix proof of attestation cron

40f016c


          add headers to api standard

0af6513

Marketen requested changes

View reviewed changes

packages/brain/src/modules/cron/sendProofOfAttestation.ts Outdated Show resolved Hide resolved

packages/brain/src/modules/apiClients/dappnodeSignerProover.ts Outdated Show resolved Hide resolved

packages/brain/src/modules/apiClients/dappnodeSignerProover.ts Outdated Show resolved Hide resolved

packages/brain/src/modules/apiClients/web3signer.ts Show resolved Hide resolved

packages/brain/src/modules/cron/sendProofOfAttestation.ts Outdated Show resolved Hide resolved

pablomendezroyo added 7 commits

May 13, 2024 19:37


          add pubkey to sign request

e00217d


          object destructuring

763df61


          implement network as query paramter

2f6d295


          fix typo

edbd07e


          remove log

ecc273d


          fix send query parameter

6f94625


          mark review fixes: rename proofOfValidation and timeout

14b052f

dappnodedev reviewed

View reviewed changes

packages/brain/src/index.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/index.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/index.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/index.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/apiClients/dappnodeSignerProover.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/apiClients/dappnodeSignerProover.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/apiClients/web3signer.ts Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/cron/cron.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/cron/reloadValidators.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/common/src/types/api/web3signer/types.ts Outdated Show resolved Hide resolved

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/envs/index.ts Outdated Show resolved Hide resolved

Marketen approved these changes

View reviewed changes

packages/brain/src/modules/cron/cron.ts Show resolved Hide resolved

packages/brain/src/modules/cron/sendProofsOfValidation.ts Outdated Show resolved Hide resolved

pablomendezroyo added 9 commits

May 29, 2024 16:23


          rename to validation and collect stader tag

c9b0e05


          rename to DappnodeSignatureVerifier

a510b1e


          move endpoint to params

b4b4f85


          add public to cron methods

f82a46a


          add interval positive number check

92ddf19


          add log if return in send proof of validation

6d909c5


          do not throw error in loading envs

2c4647a


          convert reloadValidators to function

b1ddc1c


          fix test

9581f25

dappnodedev reviewed

View reviewed changes

packages/brain/src/modules/cron/sendProofsOfValidation.ts Outdated

+                // or if there is a stader pubkey
+                if (
+                  !shareDataWithDappnode &&
+                  !Object.values(dbPubkeysDetails).some((pubkey) => pubkey.tag === "stader")

Contributor

dappnodedev May 31, 2024

But here if there is a stader pubkey will the brain send the validation proofs for all the pubkeys even if shareDataWithDappnode is disabled?

pablomendezroyo added 2 commits

May 31, 2024 10:18


          remove path module

234e157


          only send stakder keys

2ea8cd2

dappnodedev approved these changes

View reviewed changes

pablomendezroyo merged commit f098fe2 into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet