Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to solidity v. 0.5.0 #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gigatesseract
Copy link

No description provided.

@pathakcodes
Copy link

Nice work !! Your PR helped me lot with V 0.5.0 .Thanks n keep the good work.

@gigatesseract
Copy link
Author

Thank you! :) @pathakcodes
@gwmccubbin Can you merge/suggest changes in this PR?

Copy link

@joshuacox joshuacox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should have been merged in long ago?

For what it's worth I ended up coming to pretty much the same changes in my own upgrades. Though it seems to me that the build directory should be ignored in addition to the node_modules.

@@ -0,0 +1,2 @@
.gitignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the .gitignore file ignoring itself?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it seems the build directory should be ignored?

@camerenisonfire
Copy link

In case someone is running into the same issue I am having of using Solidity ^0.5.0 and getting TypeError that msg.sender is not implicitly convertible to expected type uint256:

You need to wrap msg.sender in unit256(). For example, voters[uint256(msg.sender)] = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants