Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix same candidates appearing multiple times in table #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DongsubShim
Copy link

Key changes:

Use Promise.all so all candidates are available for synchronous table update for each render() call.
Now, for two candidates, the table update would be like: (cand1 from 1st render call + cand2 from 1st) update done for 1st render … 2nd render …

Previously, multiple render() calls mixed up promises, so the table sometimes returned strange result: (cand1 from 1st + cand1 from 2nd + cand2 from 1st + cand2 from 2nd) update done for 1st and 2nd render() calls at the same time but the table showed each candidate twice.

@Meharab Meharab mentioned this pull request Jan 30, 2021
@marcopestrin
Copy link

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants