-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go to 1.21 #1331
Upgrade go to 1.21 #1331
Conversation
Signed-off-by: Pravin Pushkar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1331 +/- ##
=======================================
Coverage 22.76% 22.76%
=======================================
Files 40 40
Lines 4713 4713
=======================================
Hits 1073 1073
Misses 3562 3562
Partials 78 78 ☔ View full report in Codecov by Sentry. |
@pravinpushkar could you please resolve the conflicts? |
yes, I will work on this. |
# Conflicts: # go.sum
9e62727
to
e7c684a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the linter version for Go 1.21 support.
In Contrib we are now using v1.55.2. I suggest switching to that version.
https://github.com/dapr/cli/blob/master/.github/workflows/dapr_cli.yaml#L32
You may need to change the golangci-lint configuration and fix some new linter errors. See my PR: dapr/components-contrib#3251
Thanks for the suggestion. Just wondering, should not lint fail in this PR, all checks seems to be paasing. |
No description provided.