Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update dapr 1.12 #1343

Closed

Conversation

mukundansundar
Copy link
Collaborator

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 32.00% and project coverage change: -0.13% ⚠️

Comparison is base (41f3240) 22.95% compared to head (21b7a20) 22.82%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #1343      +/-   ##
================================================
- Coverage         22.95%   22.82%   -0.13%     
================================================
  Files                40       40              
  Lines              4697     4701       +4     
================================================
- Hits               1078     1073       -5     
- Misses             3542     3550       +8     
- Partials             77       78       +1     
Files Changed Coverage Δ
pkg/kubernetes/client.go 4.76% <ø> (ø)
pkg/kubernetes/configuration.go 0.00% <0.00%> (ø)
pkg/kubernetes/mtls.go 0.00% <0.00%> (ø)
pkg/kubernetes/renew_certificate.go 0.00% <0.00%> (ø)
pkg/kubernetes/configurations.go 53.08% <66.66%> (-5.59%) ⬇️
pkg/kubernetes/annotator.go 70.52% <100.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukundansundar
Copy link
Collaborator Author

closed by #1342

@mukundansundar mukundansundar deleted the fix-update-dapr-1.12 branch September 20, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants