Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 1.12 master #1350

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

mukundansundar
Copy link
Collaborator

@mukundansundar mukundansundar commented Sep 29, 2023

Description

Merge release 1.12 into master.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

JoshVanL and others added 3 commits September 20, 2023 18:19
* Updates the Dapr version to v1.12.0-rc.1

Signed-off-by: joshvanl <[email protected]>

* Use correct rc tag name

Signed-off-by: joshvanl <[email protected]>

* Fix string match on `HTTP server is running on port x`

Signed-off-by: joshvanl <[email protected]>

* Fix error string check for `internal gRPC server`

Signed-off-by: joshvanl <[email protected]>

* Update dapr/dapr to 1.12.0-rc.3

Signed-off-by: joshvanl <[email protected]>

* Rolling restart the sidecar injector during a restart

Signed-off-by: joshvanl <[email protected]>

* Linting

Signed-off-by: joshvanl <[email protected]>

* Fix string matching on dapr app output logs

Signed-off-by: joshvanl <[email protected]>

* Increase e2e tests `20m` -> `25m`

Signed-off-by: joshvanl <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
@mukundansundar mukundansundar requested review from a team as code owners September 29, 2023 15:59
@mukundansundar mukundansundar changed the title Merge rel 1.12 master [Do no squash] Merge rel 1.12 master Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (a08eebb) 22.95% compared to head (7a09fd6) 22.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   22.95%   22.76%   -0.19%     
==========================================
  Files          40       40              
  Lines        4697     4713      +16     
==========================================
- Hits         1078     1073       -5     
- Misses       3542     3562      +20     
- Partials       77       78       +1     
Files Coverage Δ
pkg/kubernetes/annotator.go 70.52% <100.00%> (-0.34%) ⬇️
pkg/kubernetes/client.go 4.76% <ø> (ø)
pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ø)
pkg/kubernetes/mtls.go 0.00% <0.00%> (ø)
pkg/kubernetes/configurations.go 53.08% <66.66%> (-5.59%) ⬇️
pkg/kubernetes/configuration.go 0.00% <0.00%> (ø)
pkg/kubernetes/renew_certificate.go 0.00% <0.00%> (ø)
pkg/kubernetes/run.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pravinpushkar pravinpushkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukundansundar mukundansundar changed the title [Do no squash] Merge rel 1.12 master Merge release 1.12 master Oct 4, 2023
@mukundansundar mukundansundar merged commit bb2c3a7 into dapr:master Oct 4, 2023
27 of 28 checks passed
@mukundansundar mukundansundar deleted the merge_rel_1.12_master branch October 4, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants