fix upload artifact name conflict #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mukundan Sundararajan <[email protected]>
shubham1172
reviewed
Jan 16, 2024
| @@ -181,5 +181,5 @@ jobs: | |||
| if: always() | |||
| uses: actions/upload-artifact@master | |||
| with: | |||
| name: ${{ matrix.target_os }}_${{ matrix.target_arch }}_e2e_standalone.json | |||
| name: ${{ matrix.target_os }}_${{ matrix.target_arch }}_{{dapr_install_mode}}_e2e_standalone.json | |||
Signed-off-by: Mukundan Sundararajan <[email protected]>
|
Fixing perfsprint issues in a separate issue : #1374 |
Signed-off-by: Mukundan Sundararajan <[email protected]>
mukundansundar
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
=======================================
Coverage 22.76% 22.76%
=======================================
Files 40 40
Lines 4713 4713
=======================================
Hits 1073 1073
Misses 3562 3562
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed upload artifacts version.
fix upload artifact name conflict with the migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: