Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bitnami chart version for redis #1437

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jul 23, 2024

Pins the bitnami version to a stable one and removes unneeded Redis replicas for dev mode.

Fixes #1436
and dapr/quickstarts#1048

@yaron2 yaron2 requested review from a team as code owners July 23, 2024 20:52
Copy link

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll just want to verify that the statestore CRD's creds from dapr init -k --dev work with this.

@@ -40,6 +40,7 @@ const (
daprReleaseName = "dapr"
dashboardReleaseName = "dapr-dashboard"
latestVersion = "latest"
bitnamiStableVersion = "17.14.5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified version

@paulyuk
Copy link

paulyuk commented Jul 23, 2024

We'll just want to verify that the statestore CRD's creds from dapr init -k --dev work with this.

Actually i recommend CLI no longer applies statestore anymore. This leads to too many troubleshooting conflicts. The main value here is installing redis. not applying the statestore.

@yaron2 yaron2 merged commit fecf47d into dapr:release-1.14 Jul 23, 2024
26 of 27 checks passed
@yaron2 yaron2 deleted the pinredis-1 branch July 23, 2024 22:49
@marcduiker
Copy link
Contributor

@holopin-bot @yaron2 Thanks Yaron!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @yaron2, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8i25q281130cjt9l8sfi93

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants