Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow consuming/producing Kafka tombstones when using Kafka PubSub with Avro #3510

Closed
GregerTomas opened this issue Aug 29, 2024 · 5 comments
Labels
kind/enhancement New feature or request

Comments

@GregerTomas
Copy link

Currently, consuming/producing tombstones Kafka messages is not supported when using Avro schema validation. Null values should be treated specially and not be validated by a schema.

See also https://discord.com/channels/778680217417809931/901141467840524289/1276090536976973845

@GregerTomas GregerTomas added the kind/enhancement New feature or request label Aug 29, 2024
@GregerTomas GregerTomas changed the title Allow consuminng/producing Kafka tombstones when using Kafka PubSub with Avro Allow consuming/producing Kafka tombstones when using Kafka PubSub with Avro Aug 29, 2024
@passuied
Copy link
Contributor

passuied commented Sep 4, 2024

@GregerTomas in our experience, tombstone events are supported for Avro as well... It was a bug 6+ months ago but has been addressed...
Could you provide more details about your issue?

@passuied
Copy link
Contributor

passuied commented Sep 4, 2024

@GregerTomas as mentioned on discord, we were able to reproduce the issue but only on the produce. I have a fix and will submit a PR shortly

@GregerTomas
Copy link
Author

@passuied Yes, sounds good. I was able to recieve tombstones which were sent by non-Dapr producers (aka custom Dapr header were not present). When I sent a tombstone using Dapr, I recieved mentioned error.

@passuied
Copy link
Contributor

@GregerTomas this should be resolved. Please confirm

@GregerTomas
Copy link
Author

@GregerTomas this should be resolved. Please confirm

confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants