Addressed issue in Kafka-pubsub for avro null messages #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was not properly tested end to end so the value never comes as NULL but as `"null"` which is the JSON representation Signed-off-by: Patrick Assuied <[email protected]>
|
I have validated locally that publishing 'null' will now be translated as |
… allow sending `nil` data... (returns `short buffer` error when passing empty data) Signed-off-by: Patrick Assuied <[email protected]>
yevgen-el8
approved these changes
Sep 4, 2024
Signed-off-by: Patrick Assuied <[email protected]>
evhen14
approved these changes
Sep 4, 2024
yaron2
pushed a commit
to yaron2/components-contrib
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Patrick Assuied <[email protected]>
yaron2
added a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Patrick Assuied <[email protected]> Co-authored-by: Patrick Assuied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed issue in Kafka-pubsub for avro null messages
"null"which is the JSON representationIssue reference
#3510
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: