-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for s3 list object versions operation in s3 binding #3465
add support for s3 list object versions operation in s3 binding #3465
Conversation
FYI, this PR was opened after our 1.14 code freeze unfortunately. So we likely cannot include it in 1.14 which we are in the process of releasing at the moment. |
bindings/aws/s3/s3.go
Outdated
@@ -389,6 +392,32 @@ func (s *AWSS3) list(ctx context.Context, req *bindings.InvokeRequest) (*binding | |||
}, nil | |||
} | |||
|
|||
func (s *AWSS3) listObjectVersions(ctx context.Context, req *bindings.InvokeRequest) (*bindings.InvokeResponse, error) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: no newline here please
Please sign off on your commits. Ensure you have a local copy of your branch by checking out the pull request locally via command line. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
Added new operation support within the s3 binding for listing an object's versions
Issue reference
Solves an AWS part of #3426
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: