Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go to 1.22.5 #3476

Closed
wants to merge 1 commit into from
Closed

chore: bump go to 1.22.5 #3476

wants to merge 1 commit into from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jul 3, 2024

Description

Bumps go to 1.22.5

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@mikeee mikeee requested review from a team as code owners July 3, 2024 21:03
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.14@2e35e1f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #3476   +/-   ##
===============================================
  Coverage                ?   30.13%           
===============================================
  Files                   ?      305           
  Lines                   ?    37894           
  Branches                ?        0           
===============================================
  Hits                    ?    11421           
  Misses                  ?    25504           
  Partials                ?      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berndverst
Copy link
Member

I have this included in another PR that I need to merge anyway, so I'll close this one just so I don't have to rerun my workflows :) Sorry!

You can rest assured I'm always on top of Go versions in contrib. But as an aside, setting the Go version here has no impact on Dapr runtime / the final binary.

Strictly speaking, contrib should probably set the lowest Go version it can get away with.

@berndverst
Copy link
Member

Closing this in favor of #3477

@berndverst berndverst closed this Jul 3, 2024
@mikeee mikeee deleted the bump-go branch July 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants