Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka metadata to HTTP headers conversion of invalid characters #3511

Merged

Conversation

antontroshin
Copy link
Contributor

Description

Sending special characters in Kafka message metadata will cause an error when metadata is converted to HTTP headers.
Error:

WARN[0009] Error processing Kafka message: topic/0/13 [key=]. Error: error returned from app channel while sending pub/sub event to app: retriable error occurred: Post "http://127.0.0.1:56012/handle-message": net/http: invalid header field value for "My-Header". Retrying...

Go validates header value using the function ValidHeaderFieldValue, for reference and allowed format, see more here

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3503

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@antontroshin antontroshin requested review from a team as code owners August 29, 2024 09:02
@yaron2 yaron2 merged commit 8eb716e into dapr:release-1.14 Aug 29, 2024
92 of 93 checks passed
@antontroshin antontroshin deleted the fix-kafka-metadata-headers-error branch August 29, 2024 17:11
elena-kolevska pushed a commit to elena-kolevska/components-contrib that referenced this pull request Oct 24, 2024
elena-kolevska pushed a commit to elena-kolevska/components-contrib that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants