Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Readme to favor kubectl based deploy vs. multi app run #1057

Merged
merged 14 commits into from
Jul 26, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jul 22, 2024

Description

Multi-app run has some challenges for multiple services where dependencies and timing is important, per #1048.

For this release we will keep dapr init -k --dev step in tutorial, but we will revert back to using kubectl commands for deployment.

  • there is a side issue I found and fixed. The ./deploy/redis.yaml installed a statestore component crd to kubernetes explicitly. It also deletes it. So I now delete this file from ./deploy to let the Dapr CLI handle this component, and this prevents the test from deleting the CRD as a part of deleting all deployments from .deploy, which would permanently break your dev/test environment.

Issue reference

Please reference the issue this PR will close: #1048

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk paulyuk added bug Something isn't working P1 area/tutorials labels Jul 22, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 22, 2024
@paulyuk paulyuk self-assigned this Jul 22, 2024
…t should not try to add or delete the redis.yaml crd

Signed-off-by: Paul Yuknewicz <[email protected]>

```bash
component.dapr.io/statestore created
dapr-dashboard dapr-system True Running 1 0.14.0 41s 2024-07-22 13:53.05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This output is now different in v1.14 is this matters. See dapr/cli#1434
Need to add the scheduler service

msfussell
msfussell previously approved these changes Jul 23, 2024
@paulyuk paulyuk changed the base branch from master to release-1.14 July 26, 2024 15:36
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 26, 2024

We should take this fix

  1. it works reliably fixing tutorials. finally.
  2. kubernetes users will be happy we still have a step to apply redis statestore, which no-ops if/when --dev was used to init dapr
  3. we can come back and alter this slightly if Dapr CLI stops also applying redis

@paulyuk paulyuk merged commit 64e85b5 into dapr:release-1.14 Jul 26, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tutorials bug Something isn't working P1
Projects
Development

Successfully merging this pull request may close these issues.

Tutorials Tests/Checks FAIL (dapr app not ready / timing)
3 participants