Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like powerTorch to also work with the screen on.
The difficult part seems to be still allowing the combo/multi button long presses to function.
Obviously with the combo's you try to press the buttons at the same time, but inevitably one button is pressed a fraction before the other.
This code allows the
volumeUp+power
(power menu) andvolumeDown+power
(screenshot) to work correctly.But doesn't detect
power+volumeUp
andpower+volumeDown
, and instead toggles the torch.Any hints on how to do this better would be appreciated.
I tried adding
InputMethodService.onKeyDown()
andInputMethodService.onKeyUp()
but they didn't have any noticeable effect.Also, if you were to accept such a feature addition what would be the best way to add it; would it be best to change the existing powerTorch, or leave it alone and add this as a new option?