Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add lenis-svelte to the list of plugins #374

Closed
wants to merge 1 commit into from

Conversation

DaniAcu
Copy link
Contributor

@DaniAcu DaniAcu commented Aug 2, 2024

I'm started working on svelte, and I notice lenis doesn't have a wrapper for svelte like it does for nuxt and vue. So I create the package.

If you are okay with adding this package here it will be really helpful for future svelte developer that are trying to use this awesome library in their projects.

@DaniAcu DaniAcu requested a review from a team as a code owner August 2, 2024 19:16
Copy link

vercel bot commented Aug 2, 2024

@DaniAcu is attempting to deploy a commit to the darkroom Team on Vercel.

A member of the Team first needs to authorize it.

@clementroche
Copy link
Member

Thanks @DaniAcu, what do you think about working on lenis/svelte ?

@DaniAcu
Copy link
Contributor Author

DaniAcu commented Aug 3, 2024

@clementroche do you mean inside this package? It will be great, I could create another PR to move the lib here.

I have a couple questions,

  • can I still add me as an author in the package.json?
  • I will be not having a svelte playground to show use cases, do you prefer that I add a public codesandbox for that and add it to the documentation?
  • How the publish version of lenis/svelte will works? You are doing it manually, I can be able to push a new version from my own?

@clementroche
Copy link
Member

@DaniAcu
Copy link
Contributor Author

DaniAcu commented Aug 5, 2024

Okay, I will move the package here. Do you want to have any other framework wrapper?

@clementroche
Copy link
Member

vue

@richhost
Copy link

richhost commented Oct 5, 2024

Hello, I have created a Svelte5 binding as a preview for future versions. https://github.com/richhost/svelte-lenis

@DaniAcu
Copy link
Contributor Author

DaniAcu commented Oct 6, 2024

Sorry for the delay @clementroche I will close this PR in favor of this #390.

@DaniAcu DaniAcu closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants