Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print detailed info about the leaked APIs to stdout in the workflow #339

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jan 23, 2025

  • print detailed info about the leaked APIs to stdout in the workflow
  • remove some (non-lexical) sorting from our publishing status makrdown table; with larger mono-repos, having the packages not be lexically ordered can be confusing
  • rev the firehose package version and prep for publishing
  • fix Health workflow: Show leakage origins #333

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.3.0 already published at pub.dev
package:firehose 0.10.2 ready to publish firehose-v0.10.2

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.10.1 0.10.2 0.10.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/health/health.dart 💔 94 % ⬇️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem
Copy link
Member

mosuem commented Jan 23, 2025

We could also show the origins as <details> in the comment?

@devoncarew
Copy link
Member Author

We could also show the origins as <details> in the comment?

I think this makes sense. I'd like to see what info is in the json currently, so would want to land this PR as an incremental step there.

@devoncarew devoncarew merged commit c4a163a into main Jan 23, 2025
14 checks passed
@devoncarew devoncarew deleted the print_leaked_api branch January 23, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health workflow: Show leakage origins
2 participants