Update spec to say that reporting warnings is not mandatory. #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't mean to commit this. Clicked "Squash and Merge" on the wrong tab. 🙃 |
lrhn
reviewed
Jan 23, 2024
lrhn
reviewed
Jan 23, 2024
munificent
added a commit
that referenced
this pull request
Jan 24, 2024
Incorporates feedback from: #3570.
|
I didn't mean to commit this yesterday, but we did agree to the change in the language meeting today, so this commit is now officially intended to be landed. :) |
munificent
added a commit
that referenced
this pull request
Jan 24, 2024
Incorporates feedback from: #3570.
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a larger doc to explain this but here's a proposed small change to the spec to say that warnings don't have to be reported.
@dart-lang/language-team