Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specification for enhanced parts with extension resolution #4120

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Update specification for enhanced parts with extension resolution #4120

merged 5 commits into from
Oct 7, 2024

Conversation

lrhn
Copy link
Member

@lrhn lrhn commented Oct 4, 2024 •
edited
Loading

Adds rules for resolving implicit extension applications in the new, more complicated, scope.

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

@lrhn
Update feature specification for enhanced parts with extension resolu…
5649c2e 
…tion.

Adds rules for resolving implicit extension applications in
the new, more complicated, scope.
@lrhn lrhn requested a review from jakemac53 October 4, 2024 13:10
@lrhn lrhn changed the title Update feature specification for enhanced parts with extension resolu… Update specification for enhanced parts with extension resolution Oct 4, 2024
jakemac53
jakemac53 approved these changes Oct 7, 2024
View reviewed changes
working/augmentation-libraries/parts_with_imports.md Outdated Show resolved Hide resolved
working/augmentation-libraries/parts_with_imports.md Outdated
where an extension is available by import in a Dart file if any of:
* That file contains an import directive which *imports the extension*
* That file is a part file and the extension is available by import
in its parent file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies transitively which should probably be called out in some way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now says "(recursively)".

working/augmentation-libraries/parts_with_imports.md Outdated Show resolved Hide resolved
working/augmentation-libraries/parts_with_imports.md Outdated Show resolved Hide resolved
@lrhn lrhn merged commit 3d89f16 into main Oct 7, 2024
3 checks passed
@lrhn lrhn deleted the enhanced-parts-extension-avialability branch October 7, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrhn @jakemac53