migrate public_member_api_docs integration tests (#4612)

dart-lang · Jul 24, 2023 · e78e0ce · e78e0ce
1 parent 05db75f
commit e78e0ce
Show file tree

Hide file tree

Showing 7 changed files with 54 additions and 216 deletions.
diff --git a/test/integration/public_member_api_docs.dart b/test/integration/public_member_api_docs.dart
diff --git a/test/integration_test.dart b/test/integration_test.dart
@@ -17,7 +17,6 @@ import '../test_data/rules/experiments/experiments.dart';
 import 'integration/avoid_web_libraries_in_flutter.dart'
     as avoid_web_libraries_in_flutter;
 import 'integration/close_sinks.dart' as close_sinks;
-import 'integration/public_member_api_docs.dart' as public_member_api_docs;
 import 'mocks.dart';
 import 'test_constants.dart';
 
@@ -125,7 +124,6 @@ void ruleTests() {
   group('rule', () {
     avoid_web_libraries_in_flutter.main();
     close_sinks.main();
-    public_member_api_docs.main();
   });
 }
 

diff --git a/test/rules/public_member_api_docs_test.dart b/test/rules/public_member_api_docs_test.dart
@@ -9,6 +9,7 @@ import '../rule_test_support.dart';
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(PublicMemberApiDocsTest);
+    defineReflectiveTests(PublicMemberApiDocsTestDirTest);
   });
 }
 
@@ -81,6 +82,18 @@ enum A {
     ]);
   }
 
+  test_enum_privateConstant() async {
+    await assertDiagnostics(r'''
+/// Documented.
+enum A {
+  _a;
+}
+''', [
+      // No lint.
+      error(WarningCode.UNUSED_FIELD, 27, 2),
+    ]);
+  }
+
   test_enumConstructor() async {
     await assertNoDiagnostics(r'''
 /// Documented.
@@ -212,4 +225,45 @@ final class A extends S {}
       lint(39, 1),
     ]);
   }
+
+  test_topLevelMembers() async {
+    await assertDiagnostics(r'''
+int g = 1;
+typedef T = void Function();
+int get z => 0;
+''', [
+      lint(4, 1),
+      lint(19, 1),
+      lint(48, 1),
+    ]);
+  }
+
+  test_topLevelMembers_private() async {
+    await assertDiagnostics(r'''
+int _h = 1;
+typedef _T = void Function();
+int get _z => 0; 
+''', [
+      // No lint
+      error(WarningCode.UNUSED_ELEMENT, 4, 2),
+      error(WarningCode.UNUSED_ELEMENT, 20, 2),
+      error(WarningCode.UNUSED_ELEMENT, 50, 2),
+    ]);
+  }
+}
+
+@reflectiveTest
+class PublicMemberApiDocsTestDirTest extends LintRuleTest {
+  @override
+  String get lintRule => 'public_member_api_docs';
+
+  @override
+  String get testPackageLibPath => '$testPackageRootPath/test';
+
+  test_inTestDir() async {
+    await assertNoDiagnostics(r'''
+String? b;
+typedef T = void Function();
+''');
+  }
 }
diff --git a/test_data/integration/public_member_api_docs/analysis_options.yaml b/test_data/integration/public_member_api_docs/analysis_options.yaml
diff --git a/test_data/integration/public_member_api_docs/lib/a.dart b/test_data/integration/public_member_api_docs/lib/a.dart
diff --git a/test_data/integration/public_member_api_docs/pubspec.yaml b/test_data/integration/public_member_api_docs/pubspec.yaml
diff --git a/test_data/integration/public_member_api_docs/test/b.dart b/test_data/integration/public_member_api_docs/test/b.dart